GutoVeronezi commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073957316
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 60000; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 60000;
- protected long _heartBeatUpdateFreq = 60000;
+ protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
@weizhouapache, you are missing one important point of The Apache Way:
"individuals participate at the ASF, not organizations". Again, the community
is the contributor's team; if you think some discussing/reviewing/testing is
necessary for a PR, you should request the community to it, not a company. For
instance, as I already worked with those agent properties, you could have
pinged me (as a contributor) for a second opinion.
The contributor is part of the community; if they understand and change the
project, they will be able to test and report; and that means the community has
resources to manually verify the PR (the contributors themselves are the
community). If the contributor will use their resources or their company
resources to address the request, it does not matter from ACS as a community.
As a contributor, I agree that the PR's description is not clear about the
use case, and I reinforce your remark: @stephankruggg, could you better explain
the use case for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
