weizhouapache commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1396829906
> @wido That in my view > > > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or example. Do we maybe need to set some lower and upper limits? > > @wido That is a good idea, but I'm not sure if there is a good way to validate the settings. Do you have any suggestion, where I can run those validations? @soreana you can add the validation to `validateConfigurationValue` method in `ConfigurationManagerImpl` class. a upper limit makes sense. a lower limit might be unnecessary if there is a validation to make sure the value is greater than 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
