rohityadavcloud commented on code in PR #7114:
URL: https://github.com/apache/cloudstack/pull/7114#discussion_r1082263567


##########
python/lib/cloudutils/serviceConfig.py:
##########
@@ -617,11 +617,8 @@ def config(self):
             cfo.addEntry("LIBVIRTD_ARGS", "-l")
             cfo.save()
             if os.path.exists("/lib/systemd/system/libvirtd.socket"):
-                bash("/bin/systemctl mask libvirtd.socket");
-                bash("/bin/systemctl mask libvirtd-ro.socket");
-                bash("/bin/systemctl mask libvirtd-admin.socket");
-                bash("/bin/systemctl mask libvirtd-tls.socket");
-                bash("/bin/systemctl mask libvirtd-tcp.socket");
+                bash("/bin/systemctl mask libvirtd.socket libvirtd-ro.socket 
libvirtd-admin.socket libvirtd-tls.socket libvirtd-tcp.socket");
+                bash("/bin/systemctl mask virtqemud.socket virtqemud-ro.socket 
virtqemud-admin.socket virtqemud virtnetworkd virtstoraged");
 

Review Comment:
   Yes, the notion is correct. We want to mask is the libvirtd.socket exists. 
@shwstppr can help double check this @weizhouapache 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to