DaanHoogland commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1084207504
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1462,12 +1480,12 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
}
}
- if (ntwkOff.getGuestType() != GuestType.Shared &&
(!StringUtils.isAllBlank(routerIp, routerIpv6))) {
- throw new InvalidParameterValueException("Router IP can be
specified only for Shared networks");
+ if (ntwkOff.getGuestType() == GuestType.L2 &&
(!StringUtils.isAllBlank(cmd.getRouterIPv4(), cmd.getRouterIPv6()))) {
Review Comment:
There isn´t one, but I think supported services is handled in another
location. in my tests I've seen no problems so far. Also this change is only a
small fix, allowing the router ip to be specified, which would already happen
if you don´t start and isolated network and then allocate an new IP.
Maybe there is another check you are missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
