DaanHoogland commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1085439357
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1462,12 +1480,12 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
}
}
- if (ntwkOff.getGuestType() != GuestType.Shared &&
(!StringUtils.isAllBlank(routerIp, routerIpv6))) {
- throw new InvalidParameterValueException("Router IP can be
specified only for Shared networks");
+ if (ntwkOff.getGuestType() == GuestType.L2 &&
(!StringUtils.isAllBlank(cmd.getRouterIPv4(), cmd.getRouterIPv6()))) {
Review Comment:
I'll try to break it by creating an offering without source nat and see what
I can break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
