DaanHoogland commented on code in PR #7132:
URL: https://github.com/apache/cloudstack/pull/7132#discussion_r1086611929
##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -100,9 +111,53 @@ public class ConsoleAccessManagerImpl extends ManagerBase
implements ConsoleAcce
@Override
public boolean configure(String name, Map<String, Object> params) throws
ConfigurationException {
ConsoleAccessManagerImpl.secretKeysManager = keysManager;
+ executorService = Executors.newScheduledThreadPool(1, new
NamedThreadFactory("ConsoleSession-Scavenger"));
return super.configure(name, params);
}
+ @Override
+ public boolean start() {
+ Integer consoleCleanupInterval =
ConsoleAccessManager.ConsoleSessionCleanupInterval.value();
+ Boolean consoleCleanupEnabled =
ConsoleAccessManager.ConsoleSessionCleanupEnabled.value();
+ if (BooleanUtils.isTrue(consoleCleanupEnabled)) {
Review Comment:
this would be
```suggestion
if (consoleCleanupInterval > 0) {
```
##########
server/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManagerImpl.java:
##########
@@ -100,9 +111,53 @@ public class ConsoleAccessManagerImpl extends ManagerBase
implements ConsoleAcce
@Override
public boolean configure(String name, Map<String, Object> params) throws
ConfigurationException {
ConsoleAccessManagerImpl.secretKeysManager = keysManager;
+ executorService = Executors.newScheduledThreadPool(1, new
NamedThreadFactory("ConsoleSession-Scavenger"));
return super.configure(name, params);
}
+ @Override
+ public boolean start() {
+ Integer consoleCleanupInterval =
ConsoleAccessManager.ConsoleSessionCleanupInterval.value();
Review Comment:
```suggestion
int consoleCleanupInterval =
ConsoleAccessManager.ConsoleSessionCleanupInterval.value();
```
##########
api/src/main/java/org/apache/cloudstack/consoleproxy/ConsoleAccessManager.java:
##########
@@ -18,9 +18,31 @@
import com.cloud.utils.component.Manager;
import org.apache.cloudstack.api.command.user.consoleproxy.ConsoleEndpoint;
+import org.apache.cloudstack.framework.config.ConfigKey;
public interface ConsoleAccessManager extends Manager {
+ ConfigKey<Boolean> ConsoleSessionCleanupEnabled = new
ConfigKey<>("Advanced", Boolean.class,
+ "console.session.cleanup.enabled",
+ "true",
+ "Enables/disables the console session cleanup thread.",
+ true,
+ ConfigKey.Scope.Global);
Review Comment:
we don´t need this, retention of -1 would be effectively disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
