shwstppr commented on code in PR #6840:
URL: https://github.com/apache/cloudstack/pull/6840#discussion_r1086657056
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -2164,46 +2167,56 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_POD_CREATE, eventDescription =
"creating pod", async = false)
Review Comment:
done
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -1402,54 +1402,56 @@ protected void checkIfPodIsDeletable(final long podId) {
}
}
- private void checkPodAttributes(final long podId, final String podName,
final long zoneId, final String gateway, final String cidr, final String
startIp, final String endIp, final String allocationStateStr,
Review Comment:
done
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1251,6 +1256,12 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume)
throws ResourceAllocationExc
SnapshotInfo snapshotOnPrimary =
snapshotStrategy.takeSnapshot(snapshot);
boolean backupSnapToSecondary =
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value() == null ||
SnapshotInfo.BackupSnapshotAfterTakingSnapshot.value();
+ if (backupSnapToSecondary) {
+ DataCenterVO zone =
dataCenterDao.findById(snapshot.getDataCenterId());
+ if (DataCenter.Type.Edge.equals(zone.getType())) {
+ backupSnapToSecondary = false;
+ }
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
