DaanHoogland commented on PR #7190: URL: https://github.com/apache/cloudstack/pull/7190#issuecomment-1427809711
> > @weizhouapache I reverted changes on test_vm_deployment_planner as the failures seem intemitted, and I don't see a reason. I reverted most changes on test_deploy_vm_extra_config_data, but added the possibility to call on the marvin object directly. > > The vm, which is created by deployVirtualMachine.deployVirtualMachineCmd, cannot be cleaned up by tearDown class. need to use VirtualMachine.create, like other tests, then it can be cleaned up in tearDown. Yes, I realise that. I think that is a big change now, it got me some request signing errors trying. I want to merge as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
