BryanMLima commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1440419404
Finally got time to test this again, I tested upgrading from `4.17.2.0` to `4.18.0.0` and everything went smoothly. I created two custom configurations for an account, and two for the `ROOT` domain. For the domain, one was from the `Secure` category, which was not decrypted, as the logs show below. @DaanHoogland can you call a Trillian test for this PR? ~~~ 2023-02-22 16:46:21,393 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Decrypting global configuration values from the following tables: account_details and domain_details. 2023-02-22 16:46:21,401 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Updating config with ID [1] to value [false]. 2023-02-22 16:46:21,409 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Updating config with ID [2] to value [true]. 2023-02-22 16:46:21,412 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Successfully decrypted configurations from account_details table. 2023-02-22 16:46:21,416 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Updating config with ID [1] to value [3]. 2023-02-22 16:46:21,419 INFO [c.c.u.d.Upgrade41720to41800] (main:null) (logid:) Successfully decrypted configurations from domain_details table. 2023-02-22 16:46:21,457 INFO [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup upgrade Upgrade41720to41800 to upgrade from 4.17.2.0-4.18.0.0 to 4.18.0.0 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Licensed to the Apache Software Foundation (ASF) under one 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- or more contributor license agreements. See the NOTICE file 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- distributed with this work for additional information 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- regarding copyright ownership. The ASF licenses this file 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- to you under the Apache License, Version 2.0 (the 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "License"); you may not use this file except in compliance 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- with the License. You may obtain a copy of the License at 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- http://www.apache.org/licenses/LICENSE-2.0 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Unless required by applicable law or agreed to in writing, 2023-02-22 16:46:21,465 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- software distributed under the License is distributed on an 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- KIND, either express or implied. See the License for the 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- specific language governing permissions and limitations 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- under the License. 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2023-02-22 16:46:21,466 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Schema upgrade cleanup from 4.17.2.0 to 4.18.0.0 2023-02-22 16:46:21,467 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --; 2023-02-22 16:46:21,472 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Cleanup script Upgrade41720to41800 is executed successfully 2023-02-22 16:46:21,521 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Upgrade completed for version 4.18.0.0 ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
