DaanHoogland commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1446389267
> @DaanHoogland, my point was that we would not need an attribute like `selecting the source NAT IP` in the offering; we could just validate if the offering supports the `SourceNat` service; if the offering supports the `SourceNat` service, then the source NAT IP could be informed while creating the network/VPC, otherwise, it could not. In my opinion, it is a simplier design to implement and the operators would not need to create new offerings to use the feature. What do you think? makes sense, but I would not make it obligatory, if that is what you mean, just make it an optional parameter that is accepted and validated if source NAT is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
