DaanHoogland commented on code in PR #7304:
URL: https://github.com/apache/cloudstack/pull/7304#discussion_r1122788520
##########
scripts/util/keystore-cert-import:
##########
@@ -121,6 +121,9 @@ if [ -f "$LIBVIRTD_FILE" ]; then
ln -sf /etc/pki/libvirt/servercert.pem /etc/pki/libvirt-vnc/server-cert.pem
ln -sf /etc/pki/libvirt/private/serverkey.pem
/etc/pki/libvirt-vnc/server-key.pem
cloudstack-setup-agent -s > /dev/null
+
+ chgrp qemu /etc/pki/libvirt /etc/pki/libvirt-vnc /etc/pki/CA
/etc/pki/libvirt/private /etc/pki/libvirt/servercert.pem
/etc/pki/libvirt/private/serverkey.pem /etc/pki/CA/cacert.pem
/etc/pki/libvirt-vnc/ca-cert.pem /etc/pki/libvirt-vnc/server-cert.pem
/etc/pki/libvirt-vnc/server-key.pem
+ chmod 750 /etc/pki/libvirt /etc/pki/libvirt-vnc /etc/pki/CA
/etc/pki/libvirt/private /etc/pki/libvirt/servercert.pem
/etc/pki/libvirt/private/serverkey.pem /etc/pki/CA/cacert.pem
/etc/pki/libvirt-vnc/ca-cert.pem /etc/pki/libvirt-vnc/server-cert.pem
/etc/pki/libvirt-vnc/server-key.pem
Review Comment:
isn´t 640 good enough?
##########
scripts/util/keystore-cert-import:
##########
@@ -138,6 +141,6 @@ if [ -f "$SYSTEM_FILE" ]; then
fi
# Fix file permission
-chmod 600 $CACERT_FILE
-chmod 600 $CERT_FILE
-chmod 600 $PRIVKEY_FILE
+chmod 750 $CACERT_FILE
+chmod 750 $CERT_FILE
+chmod 750 $PRIVKEY_FILE
Review Comment:
are execute bits needed for these files? seems 640 would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
