nvazquez commented on code in PR #7304:
URL: https://github.com/apache/cloudstack/pull/7304#discussion_r1126289916


##########
scripts/util/keystore-cert-import:
##########
@@ -121,6 +121,10 @@ if [ -f "$LIBVIRTD_FILE" ]; then
     ln -sf /etc/pki/libvirt/servercert.pem /etc/pki/libvirt-vnc/server-cert.pem
     ln -sf /etc/pki/libvirt/private/serverkey.pem 
/etc/pki/libvirt-vnc/server-key.pem
     cloudstack-setup-agent -s > /dev/null
+
+    QEMU_GROUP=$(sed -n 's/^group=//p' /etc/libvirt/qemu.conf | awk -F'"' 
'{print $2}')

Review Comment:
   Hi @rohityadavcloud I think this won't be a problem since we just want to 
access the qemu.conf file from the CloudStack script to obtain the group that 
the administrator has set, that won't be running as the non-root user. In case 
qemu doesn't start, then the admin may need to fix the qemu.conf file 
accordingly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to