stephankruggg commented on code in PR #7150:
URL: https://github.com/apache/cloudstack/pull/7150#discussion_r1127746390
##########
server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java:
##########
@@ -409,7 +408,8 @@ protected void validateAclRuleNumber(CreateNetworkACLCmd
createNetworkAclCmd, Ne
* <ul>
* <li>If the parameter is null, we return an {@link
InvalidParameterValueException};
* <li>Default ACLs {@link NetworkACL#DEFAULT_ALLOW} and {@link
NetworkACL#DEFAULT_DENY} cannot be modified. Therefore, if any of them is
provided we throw a {@link InvalidParameterValueException};
- * <li>If the network does not have a VPC, we will throw an {@link
InvalidParameterValueException}.
+ * <li>If no VPC is given, then it is a global ACL and there is no need
to check any VPC ID. However, if a VPC is given and it does not exist, we will
throw an
+ * {@link InvalidParameterValueException}.
Review Comment:
```suggestion
* <li>If no VPC is given, then it is a global ACL and there is no need
to check any VPC ID. However, if a VPC is given and it does not exist, throws an
* {@link InvalidParameterValueException}.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
