weizhouapache commented on code in PR #7410:
URL: https://github.com/apache/cloudstack/pull/7410#discussion_r1165340092
##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1182,7 +1183,9 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
s_logger.debug(String.format("Setting UseHttpsToUpload config on
cmdline with [%s] value.", useHttpsToUpload));
buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
- addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);
+ for (DataStore secStore : secStores) {
+ addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);
Review Comment:
@shwstppr
this will lead to multiple `secondaryStorageServerAddress=x.x.x.x` in the
cmdline
we need to handle it in SSVM (probably in `secstorage.sh`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
