shwstppr commented on code in PR #7410:
URL: https://github.com/apache/cloudstack/pull/7410#discussion_r1206769296
##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1182,7 +1183,9 @@ public boolean
finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
s_logger.debug(String.format("Setting UseHttpsToUpload config on
cmdline with [%s] value.", useHttpsToUpload));
buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
- addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);
+ for (DataStore secStore : secStores) {
+ addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);
Review Comment:
@weizhouapache I've made the changes to pass it as
`secondaryStorageServerAddress=address1,address2...`
But I couldn't find any usage of `secondaryStorageServerAddress` in
`secstorage.sh`
It is only used in ssvm-check.sh and I've added changes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
