JoaoJandre opened a new pull request, #7441:
URL: https://github.com/apache/cloudstack/pull/7441

   ### Description
   
   Currently ACS uses the `max.account.secondary.storage` setting to set the 
initial secondary storage limit for accounts. However, even after changing the 
limit for an account, the configuration value is still used to validate the 
consumption of secondary storage during the upload of volumes, templates and 
ISOs.
   This PR makes the limit defined in the account be used in the validation 
during the upload, instead of the configuration value.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   A user account was created and configured with a max secondary storage limit 
of 2 GiB, while the `max.account.secondary.storage` configuration was set to 
200GiB. 
   I uploaded two ISOs of 1GiB, and when I tried to upload a third ISO an error 
of max limit reached was received (which was expected).
   I set the `max.account.secondary.storage` to 2GiB and set the accounts max 
secondary storage to 200GiB, then I retried to upload the ISO and everything 
went ok.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to