harikrishna-patnala commented on code in PR #6442:
URL: https://github.com/apache/cloudstack/pull/6442#discussion_r1183283308
##########
.github/workflows/ci.yml:
##########
@@ -79,7 +79,8 @@ jobs:
smoke/test_metrics_api
smoke/test_migration
smoke/test_multipleips_per_nic
- smoke/test_nested_virtualization",
+ smoke/test_nested_virtualization
+ smoke/test_set_source_nat",
Review Comment:
test_set_source_nat.py smoke test file is missing !
##########
api/src/main/java/org/apache/cloudstack/api/response/IPAddressResponse.java:
##########
@@ -159,10 +159,9 @@ public class IPAddressResponse extends
BaseResponseWithAnnotations implements Co
@Param(description="the name of the Network where ip belongs to")
private String networkName;
- /*
- @SerializedName(ApiConstants.JOB_ID) @Param(description="shows the
current pending asynchronous job ID. This tag is not returned if no current
pending jobs are acting on the volume")
- private IdentityProxy jobId = new IdentityProxy("async_job");
- */
+ @SerializedName(ApiConstants.HAS_RULES)
+ @Param(description="whether the ip address has
Firewall/PortForwarding/LoadBalancing rules defined")
Review Comment:
please help me understand where this is used or how is it helpful. Also I
see we are currently setting this flag only based on firewall rules (not
portforwarding/loadbalancing rules), do we need to update the comment !
ipResponse.setHasRules(firewallRulesDao.countRulesByIpId(ipAddr.getId()) >
0);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
