shwstppr commented on code in PR #7485:
URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1188101474
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##########
@@ -286,6 +286,23 @@ public void handleSysTemplateDownload(HypervisorType
hostHyper, Long dcId) {
}
}
+ protected boolean isSkipTemplateStoreDownload(VMTemplateVO template, Long
zoneId) {
+ if (template.isPublicTemplate()) {
+ return false;
+ }
+ if (template.isFeatured()) {
+ return false;
+ }
+ if (TemplateType.SYSTEM.equals(template.getTemplateType())) {
+ return false;
+ }
+ if (zoneId != null &&
_vmTemplateStoreDao.findByTemplateZone(template.getId(), zoneId,
DataStoreRole.Image) == null) {
+ s_logger.debug(String.format("Template %s is not present on any
image store for the zone ID: %d, its download cannot be skipped",
template.getUniqueName(), zoneId));
Review Comment:
Direct-download templates are skipped (already) at line 496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
