DaanHoogland commented on code in PR #6918:
URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1093041768
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java:
##########
@@ -93,9 +93,10 @@ protected void createEmptyScopeLevelMappings() {
_scopeLevelConfigsMap.put(ConfigKey.Scope.Cluster, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.StoragePool, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.Account, new
HashSet<ConfigKey<?>>());
- _scopeLevelConfigsMap.put(ConfigKey.Scope.ImageStore, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.Domain, new
HashSet<ConfigKey<?>>());
+ _scopeLevelConfigsMap.put(ConfigKey.Scope.ImageStore, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.ManagementServer, new
HashSet<ConfigKey<?>>());
+ _scopeLevelConfigsMap.put(ConfigKey.Scope.Network, new
HashSet<ConfigKey<?>>());
Review Comment:
```suggestion
_scopeLevelConfigsMap.put(ConfigKey.Scope.Network, new HashSet<>());
```
##########
framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java:
##########
@@ -93,9 +93,10 @@ protected void createEmptyScopeLevelMappings() {
_scopeLevelConfigsMap.put(ConfigKey.Scope.Cluster, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.StoragePool, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.Account, new
HashSet<ConfigKey<?>>());
- _scopeLevelConfigsMap.put(ConfigKey.Scope.ImageStore, new
HashSet<ConfigKey<?>>());
_scopeLevelConfigsMap.put(ConfigKey.Scope.Domain, new
HashSet<ConfigKey<?>>());
+ _scopeLevelConfigsMap.put(ConfigKey.Scope.ImageStore, new
HashSet<ConfigKey<?>>());
Review Comment:
```suggestion
_scopeLevelConfigsMap.put(ConfigKey.Scope.ImageStore, new
HashSet<>());
```
diamond operator instead of type spec (not useful anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
