vishesh92 commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1217750718
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1342,6 +1507,71 @@ public boolean
upgradeKubernetesCluster(UpgradeKubernetesClusterCmd cmd) throws
return upgradeWorker.upgradeCluster();
}
+ @Override
+ public boolean addVmsToCluster(AddVirtualMachinesToKubernetesClusterCmd
cmd) {
Review Comment:
What kind of validation do you mean here? As per my understanding, the below
code takes care of the VM validation (that the uuid of the VM exists). And
later on we also check if the user has access to the VM or not.
```
@Parameter(name = ApiConstants.VIRTUAL_MACHINE_IDS, type =
CommandType.LIST,
collectionType=CommandType.UUID,
entityType = UserVmResponse.class,
required = true,
description = "the IDs of the VMs to add to the cluster")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
