DaanHoogland commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1217839430


##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1342,6 +1507,71 @@ public boolean 
upgradeKubernetesCluster(UpgradeKubernetesClusterCmd cmd) throws
         return upgradeWorker.upgradeCluster();
     }
 
+    @Override
+    public boolean addVmsToCluster(AddVirtualMachinesToKubernetesClusterCmd 
cmd) {

Review Comment:
   i understand (though i think some checks are possible) but this must be well 
documented.
   I wonder also if we can do diagnosis on any clusters that were imported. Why 
do they fail and what can be done. i might be a hypochondriac but I foresee a 
lot of user questions on this feature ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to