shwstppr commented on code in PR #7515:
URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1221161624
##########
test/integration/smoke/test_kubernetes_clusters.py:
##########
@@ -622,11 +704,10 @@ def createKubernetesCluster(self, name, version_id,
size=1, control_nodes=1):
createKubernetesClusterCmd.noderootdisksize = 10
createKubernetesClusterCmd.account = self.account.name
createKubernetesClusterCmd.domainid = self.domain.id
+ createKubernetesClusterCmd.clustertype = cluster_type
if self.default_network:
createKubernetesClusterCmd.networkid = self.default_network.id
clusterResponse =
self.apiclient.createKubernetesCluster(createKubernetesClusterCmd)
- if not clusterResponse:
- self.cleanup.append(clusterResponse)
Review Comment:
I feel this code was unnecessary. Adding clusterResponse in cleanup won't
work as we do not have code in marvin/lib/base to handle obj.delete() for a
KubernetesCluster.
Also, as far as I remember this test file tries to use the same k8s cluster
across different test cases to preserve time to deploy a new k8s cluster so
either we refactor the whole class or handle cleanup of created cluster
depending on the testcase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
