kishankavala commented on code in PR #7599:
URL: https://github.com/apache/cloudstack/pull/7599#discussion_r1221203086
##########
plugins/api/discovery/src/main/java/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java:
##########
@@ -84,6 +88,9 @@ public boolean start() {
Set<Class<?>> cmdClasses = new LinkedHashSet<Class<?>>();
for (PluggableService service : _services) {
s_logger.debug(String.format("getting api commands of service:
%s", service.getClass().getName()));
+ if
(service.getClass().getSimpleName().equals("QuotaServiceImpl") &&
PluginAccessConfigs.QuotaPluginEnabled.value()) {
Review Comment:
There are 80+ pluggable services. This QuotaServiceImpl check is very
specific and can impact performance. Should look at a generic way to fetch APIs
for a specific service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
