DaanHoogland commented on code in PR #7634:
URL: https://github.com/apache/cloudstack/pull/7634#discussion_r1231029966
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -593,7 +593,11 @@ public List<? extends Nic> getNics(long vmId) {
@Override
public String getNextAvailableMacAddressInNetwork(long networkId) throws
InsufficientAddressCapacityException {
NetworkVO network = _networksDao.findById(networkId);
- String mac = _networksDao.getNextAvailableMacAddress(networkId,
MACIdentifier.value());
+ Integer zoneIdentifyer = MACIdentifier.value();
Review Comment:
well, I set it below to the DB ID of the Zone.
I didn´t change the mac generation method itself but it should never use the
random call after this, so that is out of the equation. I think we can even
remove the random call from the getNextAvailableMacAddress-method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
