weizhouapache commented on code in PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#discussion_r1269055784


##########
plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java:
##########
@@ -365,8 +370,12 @@ private boolean loadManagementKeyStore() {
         if (managementKeyStore != null) {
             return true;
         }
-        final Certificate serverCertificate = 
issueCertificate(Collections.singletonList(NetUtils.getHostName()),
-                NetUtils.getAllDefaultNicIps(), getCaValidityDays());
+        List<String> nicIps = NetUtils.getAllDefaultNicIps();

Review Comment:
   @JoaoJandre 
   you can change the return type of the method `getAllDefaultNicIps` to 
`ArrayList<String>`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to