JoaoJandre commented on code in PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#discussion_r1286066035
##########
plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java:
##########
@@ -365,8 +370,12 @@ private boolean loadManagementKeyStore() {
if (managementKeyStore != null) {
return true;
}
- final Certificate serverCertificate =
issueCertificate(Collections.singletonList(NetUtils.getHostName()),
- NetUtils.getAllDefaultNicIps(), getCaValidityDays());
+ List<String> nicIps = NetUtils.getAllDefaultNicIps();
Review Comment:
I'm sorry, but I don't understand why I would change the return type from
`List<String>` to `ArrayList<String>`. Could you explain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
