harikrishna-patnala commented on code in PR #7746:
URL: https://github.com/apache/cloudstack/pull/7746#discussion_r1269107003
##########
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java:
##########
@@ -54,10 +55,30 @@
*/
public interface ConfigurationManager {
- public static final String MESSAGE_CREATE_POD_IP_RANGE_EVENT =
"Message.CreatePodIpRange.Event";
- public static final String MESSAGE_DELETE_POD_IP_RANGE_EVENT =
"Message.DeletePodIpRange.Event";
- public static final String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT =
"Message.CreateVlanIpRange.Event";
- public static final String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT =
"Message.DeleteVlanIpRange.Event";
+ String MESSAGE_CREATE_POD_IP_RANGE_EVENT =
"Message.CreatePodIpRange.Event";
+ String MESSAGE_DELETE_POD_IP_RANGE_EVENT =
"Message.DeletePodIpRange.Event";
+ String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT =
"Message.CreateVlanIpRange.Event";
+ String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT =
"Message.DeleteVlanIpRange.Event";
+
+ ConfigKey<Boolean> SystemVMUseLocalStorage = new ConfigKey<>(
+ Boolean.class,
+ "system.vm.use.local.storage",
+ "Advanced",
+ "false",
+ "Indicates whether to use local storage pools or shared storage
pools for system VMs.",
+ false,
+ ConfigKey.Scope.Zone,
+ null);
+
+ ConfigKey<String> ControlCidr = new ConfigKey<>(
Review Comment:
we need to add this config to getConfigKeys() method @DaanHoogland
https://github.com/shapeblue/cloudstack/blob/1275db4081aa8b09148909d6e6b65bc377d4992f/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java#L7630
##########
server/src/main/java/com/cloud/network/guru/ControlNetworkGuru.java:
##########
@@ -21,10 +21,12 @@
import javax.inject.Inject;
import javax.naming.ConfigurationException;
-import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import com.cloud.network.NetworkModel;
Review Comment:
reorder this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
