rohityadavcloud commented on code in PR #7761:
URL: https://github.com/apache/cloudstack/pull/7761#discussion_r1270447014
##########
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java:
##########
@@ -188,12 +192,25 @@ public boolean grantAccess(DataObject dataObject, Host
host, DataStore dataStore
}
@Override
- public void revokeAccess(DataObject dataObject, Host host, DataStore
dataStore)
- {
+ public void revokeAccess(DataObject dataObject, Host host, DataStore
dataStore) {
if (dataObject == null || host == null || dataStore == null) {
return;
}
+ // Workaround: don't unplug iscsi lun when volume is attached to a VM
+ // This is regression workaround from upper layers which are calling
+ // ::releaseVmResources that calls the revoke on attached disk of a VM
+ if (dataObject.getType() == DataObjectType.VOLUME) {
Review Comment:
Can be done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
