DaanHoogland commented on code in PR #7088:
URL: https://github.com/apache/cloudstack/pull/7088#discussion_r1272107143
##########
utils/src/test/java/org/apache/cloudstack/utils/redfish/RedfishClientTest.java:
##########
@@ -87,15 +87,15 @@ public void validateAddressAndPrepareForUrlTestIpv6() {
public void buildRequestUrlTestHttpsGetSystemId() {
RedfishClient redfishclient = new RedfishClient(USERNAME, PASSWORD,
true, false, REDFISHT_REQUEST_RETRIES);
String result = redfishclient.buildRequestUrl(oobAddress,
RedfishClient.RedfishCmdType.GetSystemId, systemId);
- String expected = String.format("https://%s/redfish/v1/Systems/";,
oobAddress, systemId);
Review Comment:
@weizhouapache the tests actually fail this way. Not sure if this is a bug
in the test or in the redfish code (`redfishclient.buildRequestUrl(oobAddress,
RedfishClient.RedfishCmdType.GetSystemId, systemId);`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
