jbampton opened a new pull request, #7861: URL: https://github.com/apache/cloudstack/pull/7861
### Description This PR removes the Super-Linter action which was running `flake8` and moves this check to pre-commit. We are running an older version of the GitHub Super-Linter which should be updated. So we can now run flake8 locally with pre-commit to speed up review time. Finding issues on our local machine first instead of waiting for the Super-Linter action to finish when opening a pr. Also the GitHub Actions policy of the ASF says: "You MAY use all actions internal to the apache/*, github/* and actions/* namespaces without restrictions." https://infra.apache.org/github-actions-policy.html Since the most current version of the Super-Linter is no longer under "github/*" we need to remove this action. "NOTICE: If your use of the super-linter action failed around April 26th, 2023, we changed the organization name from github to super-linter so you will need to update your references to this action from github/super-linter to super-linter/super-linter." https://github.com/super-linter/super-linter https://flake8.pycqa.org/en/latest/user/using-hooks.html https://github.com/PyCQA/flake8 When run locally with pre-commit the flake8 check found some Python files which had issues which I have ignored and these can be cleaned up or processed later if needed. <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ********************************************************************************* --> <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ********************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [X] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [X] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Run all pre-commit checks with: `pre-commit run --all-files` Just test flake8: `pre-commit run flake8 --all-files` <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
