rohityadavcloud commented on code in PR #7888:
URL: https://github.com/apache/cloudstack/pull/7888#discussion_r1301296767


##########
tools/apidoc/build-apidoc.sh:
##########
@@ -59,8 +59,12 @@ fi
 # Default case for Linux sed, just use "-i"
 sedi='-i'
 case "$(uname)" in
-  # For macOS, use two parameters
-  Darwin*) sedi='-i ""'
+  # For macOS, use two parameters, if gnu sed is not set up
+  Darwin*)
+    if ! $(which sed | grep -q gnu); then
+      sedi='-i ""'

Review Comment:
   LGTM. Gnu sed is installable via `brew install gnu-sed` which installs it on 
   ```
      PATH="/opt/homebrew/opt/gnu-sed/libexec/gnubin:$PATH"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to