harikrishna-patnala commented on issue #7375: URL: https://github.com/apache/cloudstack/issues/7375#issuecomment-1695155988
> > > value greater than VCPUs-max > > > > > > @weizhouapache I think what we are configuring about vCPUs is correct but instead of failing the VM deployment at XenServer, we should check if vCPU max is greater than the compute offering value and warn accordingly. > > Also while setting the vCPU max by comparing "xen.vm.vcpu.max" and the minimum vCPUs available in the cluster we should log the information for debugging purposes. > > @harikrishna-patnala actually cloudstack checks the host cpu cores and cpu speed in cloudstack code > > https://github.com/apache/cloudstack/blob/f563c165cb397aec3a813f15987e173ee3b7447d/server/src/main/java/com/cloud/capacity/CapacityManagerImpl.java#L413-L416 > > I doubt the check in PR#4672 is needed. Also, I think the vcpu max should not be set to the max cpu sockets, but the max cpu cores (cpu sockets * cpu cores per socket). Okay I see your point about the check which we are doing it before any ways @weizhouapache About the max value to be set, https://support.citrix.com/article/CTX236977/overcommitting-pcpus-on-individual-xenserver-vms this document says "Citrix recommends that you do not run a VM with more virtual CPUs (vCPUs) than the number physical CPUs (pCPUs) available on the XenServer host" I think this is the reason we are setting based on host details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
