weizhouapache commented on issue #7375: URL: https://github.com/apache/cloudstack/issues/7375#issuecomment-1695167184
> Okay I see your point about the check which we are doing it before any ways @weizhouapache > > About the max value to be set, https://support.citrix.com/article/CTX236977/overcommitting-pcpus-on-individual-xenserver-vms this document says "Citrix recommends that you do not run a VM with more virtual CPUs (vCPUs) than the number physical CPUs (pCPUs) available on the XenServer host" I think this is the reason we are setting based on host details. understood, thanks @harikrishna-patnala for the information. The following check applies on all hypervisor types, which might be good enough. ``` boolean isCpuNumGood = host.getCpus().intValue() >= cpuNum; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
