weizhouapache commented on PR #7887: URL: https://github.com/apache/cloudstack/pull/7887#issuecomment-1695227602
> > > @harikrishna-patnala @DaanHoogland I thought about it again, I think we should not set the vcpu max limit to the minimum cpu cores of host in the cluster. it might be possible that some hosts have enough capacity (cpu cores and cpu speed), but vms cannot be deployed. > > > > > > you are right @weizhouapache , we should actually set it to the maximum for any host in the cluster, if at all. I wonder if the setting is meant for operators to have some control over the kind of VMs that can be deployed... > > My opinion is we either use the setting or specific host cpu details (decided by the deployment planner). Using maximum of any host in the cluster may result in using higher value in host which has lower capacity in the cluster (host which is decided by the deployment planner) @harikrishna-patnala good discussion. Based on it, I updated the PR to set the vmr.VCPUsMax to minimum of global setting and cpu cores of specific hosts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
