GutoVeronezi commented on PR #7895:
URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1696021793

   > > @JoaoJandre You can generate the uri by settings in db properties
   > > 
   > > * driver
   > > * replicas
   > > * failover mode (new)
   > > * url params
   > > 
   > > what else are missing ?
   > 
   > @JoaoJandre I am ok if you add a new `db.cloud.uri`, however, please 
ensure that the following configurations will generate the same uri
   > 
   > ```
   > db.cloud.driver=jdbc:mariadb
   > db.cloud.failover.mode=sequential
   > 
db.cloud.replicas=192.168.201.160:3306,192.168.201.161:3306,192.168.201.162:3306
   > db.cloud.autoReconnect=true
   > 
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC
   > ```
   > 
   > to
   > 
   > ```
   > db.cloud.driver=jdbc:mariadb
   > 
db.cloud.uri=jdbc:mariadb:sequential://192.168.201.160:3306,192.168.201.161:3306,192.168.201.162:3306/cloud?autoReconnect=true&prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC
   > ```
   
   @weizhouapache seems to me that the PR's scope is to allow the full URI 
definition, not to extend the current hard coded properties behavior; 
therefore, it does not make sense to me to require an extension out of the 
scope. 
   
   Also, what is the point on having (and adding) several configurations that 
operators will have to learn how they work on CloudStack instead of having a 
single one that represents the full URI, that operators are used to work with?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to