GutoVeronezi commented on PR #7895:
URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1696423344
> > > @GutoVeronezi cc @JoaoJandre You only mentioned the flexible URI in
the title and description. However, there are lots of changes for mariadb
support. please remove the changes for mariadb support, if it is out of scope,
as you said.
> >
> >
> > @weizhouapache it is the contributors will to add the MariaDB support,
not a requirement from another contributor; also there are 6 lines adding
support for MariaDB, which is far from "lots of changes", but I do agree this
should be added to the PR's description, as the PR's description should
describe in details what the PR is introducing and changing, to facilitate
revision and tracking of changes. @JoaoJandre, please, could you mention the
MariaDB support in the PR's title and description?
>
> @GutoVeronezi If you add the mariadb support to the scope, I think it is
not fully done: the failover mode is not configurable (except uri).
>
> > > > @weizhouapache seems to me that the PR's scope is to allow the full
URI definition, not to extend the current hard coded properties behavior;
therefore, it does not make sense to me to require an extension out of the
scope.
> > > > Also, what is the point on having (and adding) several
configurations that operators will have to learn how they work on CloudStack
instead of having a single one that represents the full URI, that operators are
used to work with?
> > >
> > >
> > > Because URI is not user-friendly. it is suitable to premium users, but
not for normal users.
> >
> >
> > Normal users are able to describe a simple URI, it only needs to be
well-documented. Anyways, the support for lots of properties to configure the
connection is kept (the properties that we have so far); therefore, no problems
will be created for users that are used to the current pattern.
>
> Currently for normal users, they just need to specify the db host ip. In
order to support mariadb, they might need to specify the driver, failover mode
and replicas, but it is still much more simple and friendly than the URI. To
achieve it, we just need to add the new property for failover mode, which is
not complicated.
@weizhouapache, a contributor is not bound to address all the use cases. If
the author is adding support to MariaDB with the full URI, we have to guarantee
that the use case is being addressed and the changes are not breaking
compatibility; other than that, is the author's choice to add support for other
use cases or not. Therefore, it is on @JoaoJandre to choose adding the support
for hardcoded properties or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
