weizhouapache commented on code in PR #7922:
URL: https://github.com/apache/cloudstack/pull/7922#discussion_r1309727936
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/DbUpgradeUtils.java:
##########
@@ -21,7 +21,15 @@
public class DbUpgradeUtils {
- private static DatabaseAccessObject dao = new DatabaseAccessObject();
+ private static final DatabaseAccessObject dao = new DatabaseAccessObject();
Review Comment:
it seems this causes the test error
```
08:07:02 [ERROR]
testDropPrimaryKey(com.cloud.upgrade.dao.DbUpgradeUtilsTest) Time elapsed:
0.706 s <<< ERROR!
08:07:02 java.lang.NullPointerException
08:07:02 at
com.cloud.upgrade.dao.DbUpgradeUtilsTest.testDropPrimaryKey(DbUpgradeUtilsTest.java:96)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
