nvazquez commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1703857655
@itsayushpandey I have been testing the PR and overall is working fine, well done! I have found the following cases to fix, from the most to the least critical: - Wrong network selection: To reproduce it you can create 2 networks: one Isolated network and one L2 network. Create a VM on the L2 network and then unmanage it. Then try managing it back selecting the L2 network -> the imported VM gets deployed on the Isolated network. - Fixed service offerings still doesn't work: The check fails since the logic says the CPU speed doesn't match the CPU speed of the offering (https://github.com/apache/cloudstack/blob/main/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java#L428). It is weird as I have made sure I select the same offering from which I try to import. However CloudStack still thinks they are different: Failed to import VM: i-2-23-VM. Service offering (da88a0aa-bf82-40ae-ab32-a6e4c88b5ce8) 500MHz CPU speed does not match VM CPU speed 250MHz and VM is not in powered off state (Power state: PowerOn) - Minor UI improvements: - After the import VM dialog is closed, the button is still loading and you need to refresh the UI to get it functional again. I think this is a simple fix, once the API is finished you can set the variable loading = false in the .vue file - The Import/Export title still says the feature is only supported on Vmware, we can add KVM now to that text -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
