mlsorensen commented on code in PR #7971:
URL: https://github.com/apache/cloudstack/pull/7971#discussion_r1330451705


##########
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java:
##########
@@ -110,7 +110,7 @@ public AgentControlAnswer processControlCommand(long 
agentId, AgentControlComman
     @Override
     public void processHostAdded(long hostId) {
         HostVO host = hostDao.findById(hostId);
-        if (host != null) {
+        if (host != null && 
HypervisorType.KVM.equals(host.getHypervisorType())) {

Review Comment:
   Looking into this a bit further @rohityadavcloud @nvazquez - I'm not sure 
why CustomServerDiscoverer extends LibvirtServerDiscoverer, or if it's even 
necessary for the CustomServerDiscoverer to exist since presumably custom 
hypervisor would provide their own Discoverer.
   
   If not for this, I could just make the check 
`getHypervisorType().equals(host.getHypervisorType())`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to