mlsorensen commented on code in PR #7987:
URL: https://github.com/apache/cloudstack/pull/7987#discussion_r1333632203
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -452,6 +452,8 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
private long _dom0OvercommitMem;
+ private int _dom0MinCpuCores;
Review Comment:
@GutoVeronezi - then it will never get done, we will just make it more
inconsistent and confusing until maybe at some point in the distant future all
code is replaced :-) If there is nobody actively rebuilding the Ship of Theseus
then it will always be a hodgepodge of parts.
I have created a PR to refactor all variable names for
LibvirtComputingResource, and the same for all classes that were dependent on
those variables and also changed. Then I can make the change requested here
without triggering my OCD by making style consistency worse.
https://github.com/apache/cloudstack/pull/7991
I will refactor this PR, or that PR, depending on which gets merged first.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
