mlsorensen commented on code in PR #7987:
URL: https://github.com/apache/cloudstack/pull/7987#discussion_r1333512609
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -452,6 +452,8 @@ public class LibvirtComputingResource extends
ServerResourceBase implements Serv
private long _dom0OvercommitMem;
+ private int _dom0MinCpuCores;
Review Comment:
@GutoVeronezi @DaanHoogland - even if it causes mixed style in a class? I'd
rather someone go through and fix style for the whole class as a separate
effort to at least keep things looking clean and consistent.
Thinking for all contributors, it is reasonable for a developer to match the
existing style. If we want to avoid having contributors do so, we should put an
effort into changing the style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
