GutoVeronezi commented on code in PR #7991:
URL: https://github.com/apache/cloudstack/pull/7991#discussion_r1333643933
##########
agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java:
##########
@@ -83,16 +83,16 @@
public class ConsoleProxyResource extends ServerResourceBase implements
ServerResource {
static final Logger s_logger =
Logger.getLogger(ConsoleProxyResource.class);
- private final Properties _properties = new Properties();
- private Thread _consoleProxyMain = null;
+ private final Properties properties = new Properties();
+ private Thread consoleProxyMain = null;
- long _proxyVmId;
- int _proxyPort;
+ long proxyVmId;
+ int proxyPort;
- String _localgw;
- String _eth1ip;
- String _eth1mask;
- String _pubIp;
+ String localgw;
Review Comment:
@mlsorensen, as we are touching these declarations, what do you think about
renaming some of them, like fixing the camelCase and describing them better?
For instance:
```suggestion
String localGateway;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
