GutoVeronezi commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1738971647
> @GutoVeronezi , I just tried to review the link in the description and it seems to be gone, can you check? `An error code 404 occured while trying to fetch https://lists.apache.org/api/thread.lua?id=qvb3kx78m7lvc21d90ld00v8o8wd27r: Content not found ` @DaanHoogland I may have bumped the backspace button accidentally while writing the description, the link was missing the final character. I adjusted the description, the correct link is https://lists.apache.org/thread/qvb3kx78m7lvc21d90ld00v8o8wd27ro. > any progress on this @GutoVeronezi ? The topics described in https://github.com/apache/cloudstack/pull/7417#issuecomment-1500783920 will guide us in defining how to use it and guaranteeing that everyone complies with the new pattern. Resuming the discussion of them: Regarding point `a`, I believe creating a file for each `VIEW` is the best option; it will require more effort on backporting, however, it will bring us more organization and better backtracking. About point `b`, I do not have a formed opinion about it; we could go either way; we would just have to adjust the GH Actions (yet to be done) to comply with it. In respect of point `c` (and also @DaanHoogland's comment -- https://github.com/apache/cloudstack/pull/7417#discussion_r1168510398), the point in creating `VIEW` is to help us better handle the data via Java. In the schema files, we have total flexibility to use SQL as we want; therefore, if necessary to use a `VIEW` logic at some point, we could reproduce it easily in the query. With that, we might want to execute the `VIEW` scripts only after applying all the patches, as @DaanHoogland wondered. What are your thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
