JoaoJandre commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1340559344
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java:
##########
@@ -5065,6 +5079,29 @@ private Answer execute(MigrateVolumeCommand cmd) {
volumePath = vmMo.getVmdkFileBaseName(disk);
}
}
+ if (cmd.getNewIops() != null) {
+ String vmwareDocumentation =
"https://kb.vmware.com/s/article/68164";;
+ Long newIops = cmd.getNewIops();
+ VirtualDisk disk = vmMo.getDiskDevice(volumePath,
true).first();
Review Comment:
This method will try to get the file name based on the volumePath, to do
this, it will try to strip the extension from the path. However, the volumePath
comes from the database already stripped of the extension.
This is generally not an issue, but if the file name has a (`.`) in it, it
will get split and the method will fail. We should either refactor that method
to take this into account, or create a new one for this use case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
