weizhouapache commented on code in PR #7728:
URL: https://github.com/apache/cloudstack/pull/7728#discussion_r1341328704
##########
plugins/ca/root-ca/src/main/java/org/apache/cloudstack/ca/provider/RootCAProvider.java:
##########
@@ -365,8 +370,12 @@ private boolean loadManagementKeyStore() {
if (managementKeyStore != null) {
return true;
}
- final Certificate serverCertificate =
issueCertificate(Collections.singletonList(NetUtils.getHostName()),
- NetUtils.getAllDefaultNicIps(), getCaValidityDays());
+ List<String> nicIps = NetUtils.getAllDefaultNicIps();
Review Comment:
ok @JoaoJandre
I have not faced the issue before that same Ip is assigned to multiple nics.
it is ok anyway.
have you considered the scenario that there are multiple management IPs on
the management interface ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
