DaanHoogland commented on code in PR #8022: URL: https://github.com/apache/cloudstack/pull/8022#discussion_r1345539957
########## ui/src/views/image/RegisterOrUploadTemplate.vue: ########## @@ -1,3 +1,4 @@ + Review Comment: (1) is a no go i think , not from a test perspective at least (2) would have my preference (3) is not ideal but could work if the execution order of the tests is guaranteed. as seen in https://github.com/apache/cloudstack/pull/8022#issuecomment-1746102149, if test 1 fails, all do. even while test 1 failure is environmental. any comment @borisstoyanov ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
