DaanHoogland commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1352549956
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -530,10 +530,10 @@ public class AgentProperties{
/**
* Heartbeat update timeout (in ms).<br>
* Depending on the use case, this timeout might need
increasing/decreasing.<br>
- * Data type: Integer.<br>
- * Default value: <code>60000</code>
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
*/
- public static final Property<Integer> HEARTBEAT_UPDATE_TIMEOUT = new
Property<>("heartbeat.update.timeout", 60000);
+ public static final Property<Long> HEARTBEAT_UPDATE_TIMEOUT = new
Property<>("heartbeat.update.timeout", 60000l);
Review Comment:
```suggestion
public static final Property<Long> HEARTBEAT_UPDATE_TIMEOUT = new
Property<>("heartbeat.update.timeout", 60000L);
```
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
*/
public static final Property<String> CONTROL_CIDR = new
Property<>("control.cidr", "169.254.0.0/16");
+ /**
+ * Time interval (in milliseconds) between KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new
Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+ /**
+ * Number of maximum tries to KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>5l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new
Property<>("kvm.heartbeat.update.max.tries", 5l);
+
+ /**
+ * Time amount (in milliseconds) for the KVM heartbeat retry sleep. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>10000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP = new
Property<>("kvm.heartbeat.update.retry.sleep", 10000l);
+
+ /**
+ * Timeout (in milliseconds) of the KVM heartbeat checker. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>360000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_CHECKER_TIMEOUT = new
Property<>("kvm.heartbeat.checker.timeout", 360000l);
Review Comment:
```suggestion
public static final Property<Long> KVM_HEARTBEAT_CHECKER_TIMEOUT = new
Property<>("kvm.heartbeat.checker.timeout", 360000L);
```
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -530,10 +530,10 @@ public class AgentProperties{
/**
* Heartbeat update timeout (in ms).<br>
* Depending on the use case, this timeout might need
increasing/decreasing.<br>
- * Data type: Integer.<br>
- * Default value: <code>60000</code>
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
Review Comment:
```suggestion
* Default value: <code>60000L</code>
```
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
*/
public static final Property<String> CONTROL_CIDR = new
Property<>("control.cidr", "169.254.0.0/16");
+ /**
+ * Time interval (in milliseconds) between KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new
Property<>("kvm.heartbeat.update.frequency", 60000l);
Review Comment:
```suggestion
public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new
Property<>("kvm.heartbeat.update.frequency", 60000L);
```
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
*/
public static final Property<String> CONTROL_CIDR = new
Property<>("control.cidr", "169.254.0.0/16");
+ /**
+ * Time interval (in milliseconds) between KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new
Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+ /**
+ * Number of maximum tries to KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>5l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new
Property<>("kvm.heartbeat.update.max.tries", 5l);
+
+ /**
+ * Time amount (in milliseconds) for the KVM heartbeat retry sleep. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>10000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP = new
Property<>("kvm.heartbeat.update.retry.sleep", 10000l);
Review Comment:
```suggestion
public static final Property<Long> KVM_HEARTBEAT_UPDATE_RETRY_SLEEP =
new Property<>("kvm.heartbeat.update.retry.sleep", 10000L);
```
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -731,6 +731,38 @@ public Property<Integer> getWorkers() {
*/
public static final Property<String> CONTROL_CIDR = new
Property<>("control.cidr", "169.254.0.0/16");
+ /**
+ * Time interval (in milliseconds) between KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>60000l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_FREQUENCY = new
Property<>("kvm.heartbeat.update.frequency", 60000l);
+
+ /**
+ * Number of maximum tries to KVM heartbeats. <br>
+ * This property is for KVM only.
+ * Data type: Long.<br>
+ * Default value: <code>5l</code>
+ */
+ public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new
Property<>("kvm.heartbeat.update.max.tries", 5l);
Review Comment:
```suggestion
public static final Property<Long> KVM_HEARTBEAT_UPDATE_MAX_TRIES = new
Property<>("kvm.heartbeat.update.max.tries", 5L);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
