mlsorensen commented on PR #8012: URL: https://github.com/apache/cloudstack/pull/8012#issuecomment-1771229808
I got some time to review the recent change that is conflicting (https://github.com/apache/cloudstack/commit/3e7f21a19091fab9a9eaa6154c92560e8955ad4c). I think I have updated properly, and fixed a potential issue with the commit. The commit introduced the idea that searching for VMs by cluster ID should include not just the `host_id` but also the `last_host_id`, presumably to capture stopped VMs as well, where the current host ID is not set. However, in the event that the VM is on zone wide storage, this could make a VM look like it is in two different clusters if the VM stops in one cluster and starts in another, since we would be matching in both the current cluster and the last cluster it ran in. To resolve this I qualified the search on `last_host_id` to only apply if the VM is stopped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
