weizhouapache commented on code in PR #8122:
URL: https://github.com/apache/cloudstack/pull/8122#discussion_r1374262073
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -3816,14 +3816,6 @@ public PhysicalNetwork createPhysicalNetwork(final Long
zoneId, final String vne
throw new InvalidParameterException("Only one isolationMethod can
be specified for a physical network at this time");
}
- if (vnetRange != null) {
- // Verify zone type
- if (zoneType == NetworkType.Basic || (zoneType ==
NetworkType.Advanced && zone.isSecurityGroupEnabled())) {
Review Comment:
Good point, thanks @shwstppr
I will create a Basic zone and test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
