DaanHoogland commented on code in PR #8122:
URL: https://github.com/apache/cloudstack/pull/8122#discussion_r1374465216


##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -3816,6 +3816,10 @@ public PhysicalNetwork createPhysicalNetwork(final Long 
zoneId, final String vne
             throw new InvalidParameterException("Only one isolationMethod can 
be specified for a physical network at this time");
         }
 
+        if (vnetRange != null && zoneType == NetworkType.Basic) {
+            throw new InvalidParameterValueException("Can't add vnet range to 
the physical network in the Basic zone");
+        }
+

Review Comment:
   seems like a new method to be called in two places @weizhouapache ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to